My opinion is that we share a house, a life, a love, so also money.
There have been times when he made all the money (and I got to spend it all

) and where I have made all the money, or when we both made money (or both didnīt make money).
As long as the 2 people involved are clear on what the agreements are I see no problem with that.
Some things I believe you should make clear agreements on:
How much goes to savings
How much can you spend on "silly" things
What are "silly" things (for us they are thingies in the house that we donīt need, xbox games, gifts for people without anything special going on etc)
From which amount do we talk to the other person to see if we both are ok buying it